Use .charAt() instead of array-style string indexing to appease IE7 and below #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I shouldn't have bumped the version number? Apologies if that was presumptuous, I mainly did it for my own purposes. |
codler
added a commit
that referenced
this pull request
May 8, 2012
Use .charAt() instead of array-style string indexing to appease IE7 and below
|
Thank you for the fix! It was correctly bumped version so no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting an error in IE7:
This was because IE7 and lower do not support array-style string indexes. This pull request includes a tiny change to use
.charAt()instead.