Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binary): Added support for Linux Arm #154

Closed

Conversation

RedFlame2112
Copy link

Added an additional control path to the
arch_and_platform() function that accounts for the recent Linux ARM path for reference ARM based distros like Fedora Asahi Remix. Might need some additional testing though with other ARM linux distributions besides Asahi as a reference (e.g. archlinux arm)

@RedFlame2112 RedFlame2112 requested a review from amirbilu as a code owner March 8, 2024 20:37
@amirbilu
Copy link
Contributor

amirbilu commented Mar 8, 2024

Hi @RedFlame2112 thanks for the contribution! Unfortunately Tabnine binary is not compiled for linux arm.. so this won't really work

@aarondill
Copy link
Contributor

aarondill commented Mar 9, 2024

@amirbilu I'm happy to rebase and continue #82 (which would also fix #77) if you review it and give your feedback on the direction

Added an additional control path to the
`arch_and_platform()` function that accounts for the recent Linux ARM path for reference ARM based distros like Fedora Asahi Remix
@amirbilu amirbilu force-pushed the add-aarch64-linux-support branch from 05c3bf9 to 88ec367 Compare March 18, 2024 08:35
@amirbilu amirbilu closed this Mar 18, 2024
@amirbilu
Copy link
Contributor

hi @RedFlame2112 we're adding arm support soon. Will you be willing to test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants