Not able to match `@null@||@array@` (again)

[Aerendir]

There is already a closed issue that reports my same exact problem:

• Not able to match @null@||@array@ #212

My array structure is almost this:

{
    "@context": "\/api\/contexts\/MyClass",
    "@id": "\/api\/myclasses\/2",
    "hydra:member": [
        {
            "id": 1,
            "my_key": {
                "key1": "EUR",
                "key2": 0.22
            }
        }
    ]
}

my_key can also be null:

{
    "@context": "\/api\/contexts\/MyClass",
    "@id": "\/api\/myclasses\/2",
    "hydra:member": [
        {
            "id": 1,
            "my_key": null
        }
    ]
}

So, to validate this structure, I use this pattern:

[
                '@context'         => '/{app_api_entrypoint}/contexts/' . StringHelper::getClassBaseName(Item::class),
                '@id'              => '/{app_api_entrypoint}{api_endpoint}',
                '@type'            => 'hydra:Collection',
                'hydra:totalItems' => AbstractItemsFixture::COUNT_TOTAL_IN_ACCOUNT,
                'hydra:member'     => [
                    [
                        '@id' => '@string@',
                        'my_key' => '@array@ || @null@',
...

This validation does not pass:

Failed asserting that Value "Array(2)" does not match pattern "[hydra:member][0]" at path: "[hydra:member][0][my_key]".

Am I doing it wrong or is it actually a bug?

[norberttech]

Hey @Aerendir it looks like a bug. It seems that or condition is not handled properly and it's failing whenever the first check fails.

[Aerendir]

I don't know... I tried to debug, but I'm not so used to the library, so I didn't had a good result...

Anyway, the live sandbox is very useful!

You should put it in a template for GitHub when opening a bug issue, asking to reproduce the problem...

[norberttech]

You should put it in a template for GitHub when opening a bug issue, asking to reproduce the problem...

Done!

[GeLoLabs]

The issue comes from the "MatcherFactory", it builds an "ArrayMatcher" which uses an "OrMatcher" which don't use any "ArrayMatcher" in its chain and so this "OrMatcher" (which is different from the one used by the main matcher) is not able to match "@array@" (see https://github.com/coduo/php-matcher/blob/6.x/src/Factory/MatcherFactory.php#L52)