Fix UUID pattern #400
Merged
Fix UUID pattern #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Changed
Description
The currently UUID isn't exactly a general UUID matcher, but a variant-specific matcher.
For example, the NIL UUID doesn't match, although it's a valid, UUID as defined in the UUID spec. Also, restricting the version and variant isn't exactly right, since using other hex digit is valid, meaning the version and variant are unknown. Even the most used UUID library in the PHP ecosystem, or the native UUID in Java, doesn't impose such restrictions.