-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pending changelog for unreleased changes #51
base: master
Are you sure you want to change the base?
Conversation
Hey @joeyparis, First of all I would like to thank you for the time and effort you put creating these issues and PRs, your contributions are greatly appreciated! Secondly, my first reaction upon seeing this PR was
Maybe you didn't know about this flag? Assuming you did know about the flag:
|
Hey @emilianoLeite, I did actually know about that flag which is what I used as an example for creating this pull request! The reason that flag is not sufficient for us is that it only works in the CLI, but the people at our company who it benefits the most have no CLI/programming experience. Basically, our deployment process involves us deploying a bunch of changes to our staging environment where it is then tested. This pending changelog is what the testers use as a sort of checklist on what to test. The testers don't have access to any source code or CLI experience, so this is an easy way for them to know exactly what's included in this staging deployment without having to commit those changes to an actual release, as some may not pass testing. I opted for creating a separate file because it made it easier to include the pending changelog on stage only and not production. That being said, from the perspective of just this ruby gem I agree that adding a section in |
Okay, I believe I've adjusted the PR to work as requested. There are also two minor unrelated changes included in this PR request. I added a test for the release preview flag, and additional regenerate tests to increase coverage to 100%, and fixed 2 Rubocop offenses for 100% rubocop satisfaction. |
Co-authored-by: Guilherme Moreira Santos <gmoreirasantos1325@hotmail.com>
… pending changes after a new release
I just wanted to check-in to see if we could get this merged into the official release! I've been using it locally now for a while and it's been very helpful. Thanks! |
Objective
Solves #50. Adds the ability to generate a "pending changelog" of all unreleased changes. Our personal use case for this is so we can easily display a list of changes that should be tested but are not ready to be committed as a "release" yet.
Notes
Adds two new setting config options:
default_pending_changelog_filename
which defaults to CHANGELOG_PENDING.mddefault_pending_changelog_title
which defaults to Pending ChangesI chose CHANGELOG_PENDING over PENDING_CHANGELOG so that CHANGELOG.md and CHANGELOG_PENDING.md are right next to each other in the file directory.
I'm not super happy with the naming conventions so I'm definitely open to suggestions about different names than just "pending".
How to test
Run
rake
for automated testing.To test manually run
bundle exec bin/codelog pending
while you have unreleased changes then check CHANGELOG_PENDING.md for a list of your unreleased changes.Breaking changes
No breaking changes.
Checklist