-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack optimization
configuration is not supported anymore
#587
Comments
karma-webpack introduced a breaking change in v5.0.1 that breaks our test suite: codymikol/karma-webpack#587
karma-webpack introduced a breaking change in v5.0.1 that breaks our test suite: codymikol/karma-webpack#587
we should not dictate this behavior, just warning users that this may lead to unexpected behavior should suffice. Fixes #587
we should not dictate this behavior, just warning users that this may lead to unexpected behavior should suffice. Fixes #587 Co-authored-by: Cody Mikol <cody.mikol@boltstech.com>
Hi @codymikol, we were happy to see 5.0.1 released, and wanted to upgrade in the Firebase JS SDK so that we can remove our usage of patch-package to patch in our fix (f734b10) from a few years ago onto 5.0.0. It turns out we relied on setting When can we expect this fix to be released? |
I'll cut a release this weekend |
That's great news for us, thank you!! |
@codymikol Any updates on when we can expect to see this fix released? |
Before v5,
karma-webpack
built one independent bundle per spec file that included every spec dependencies.With v5.0.0, the new behavior is to use a single common chunk that includes all the code (source and spec). We were able to roll back to the previous behavior by leveraging the
optimization
webpack option (see code).With v5.0.1, it is now forbidden to set the
optimization
webpack option (see f2327b1), so our workaround does not work anymore, and upgrading to v5.0.1 breaks our test suite.Expected Behavior
karma-webpack v5.0.1 should not introduce a breaking change and should still support the
optimization
webpack option. As an alternative,karma-webpack
could introduce an option to restore pre-v5 behavior (one independent bundle per spec file).Actual Behavior
karma-webpack v5.0.1 does not support the
optimization
webpack option.How Do We Reproduce?
The text was updated successfully, but these errors were encountered: