Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use os.tmpdir() to safely store _karma_webpack_ #279

Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix: use os.tmpdir() to safely store _karma_webpack_ #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/karma-webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
var os = require('os')
var _ = require('lodash')
var path = require('path')
var async = require('async')
Expand Down Expand Up @@ -47,8 +48,8 @@ function Plugin(

// Must have the common _karma_webpack_ prefix on path here to avoid
// https://github.com/webpack/webpack/issues/645
webpackOptions.output.path = '/_karma_webpack_/' + indexPath
webpackOptions.output.publicPath = '/_karma_webpack_/' + publicPath
webpackOptions.output.path = path.join(os.tmpdir(), '_karma_webpack_', indexPath)
webpackOptions.output.publicPath = path.join(os.tmpdir(), '_karma_webpack_', publicPath)
webpackOptions.output.filename = '[name]'
if (includeIndex) {
webpackOptions.output.jsonpFunction = 'webpackJsonp' + index
Expand Down Expand Up @@ -132,11 +133,11 @@ function Plugin(
}
}.bind(this))

webpackMiddlewareOptions.publicPath = '/_karma_webpack_/'
webpackMiddlewareOptions.publicPath = path.join(os.tmpdir(), '_karma_webpack_')
var middleware = this.middleware = new webpackDevMiddleware(compiler, webpackMiddlewareOptions)

customFileHandlers.push({
urlRegex: /^\/_karma_webpack_\/.*/,
urlRegex: new RegExp('^' + os.tmpdir() + '\/_karma_webpack_\/.*/'),
handler: function(req, res) {
middleware(req, res, function() {
res.statusCode = 404
Expand Down Expand Up @@ -197,7 +198,7 @@ Plugin.prototype.readFile = function(file, callback) {
var doRead = function() {
if (optionsCount > 1) {
async.times(optionsCount, function(idx, callback) {
middleware.fileSystem.readFile('/_karma_webpack_/' + idx + '/' + file.replace(/\\/g, '/'), callback)
middleware.fileSystem.readFile(path.join(os.tmpdir(), '_karma_webpack_', idx, file.replace(/\\/g, '/')), callback)
}, function(err, contents) {
if (err) {
return callback(err)
Expand All @@ -214,7 +215,7 @@ Plugin.prototype.readFile = function(file, callback) {
})
} else {
try {
var fileContents = middleware.fileSystem.readFileSync('/_karma_webpack_/' + file.replace(/\\/g, '/'))
var fileContents = middleware.fileSystem.readFileSync(path.join(os.tmpdir(), '_karma_webpack_', file.replace(/\\/g, '/')))

callback(undefined, fileContents)
} catch (e) {
Expand Down