fix(webpack): use path.resolve to create file path #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
I'm getting
no such file or directory
error fromkarma-webpack
:I think the issue is that
/var
is a symlink to/private/var
, andreadFileSync
incorrectly (or correctly?) resolve the path to/private/Users/feiyangc/Projects/firebase-js-sdk/packages/logger/dist/src/logger.d.ts
while the correct path should be without/private
.Using
path.resolve
creates the correct file path.Breaking Changes
Additional Info