journal: adjust open() mechanisms to use a builder pattern #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unclear what the use case is.
… instead of a null ptr
codyps
force-pushed
the
license-cleanup
branch
2 times, most recently
from
fbeb4a5 to
4c5f05c
Compare
…support Keeps `Journal::open()` for now, but mark it and `JournalFiles` as deprecated
codyps
force-pushed
the
license-cleanup
branch
from
4c5f05c to
05802e1
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 3, 2020
154: journal: adjust open() mechanisms to use a builder pattern r=jmesmon a=jmesmon - `JournalFiles` doesn't properly cover all inclusions/exclusions - The various boolean arguments were leading to "boolean blindness" (ie: lack of clarity in what `open()` call options meant). - `OpenOptions`, `OpenFileOptions`, and `OpenDirectoryOptions` are added. These are patterned after `std::fs::OpenOptions`. - I've marked the commonly used `Journal::open()` as deprecated (and was somewhat annoyed by rust-lang/rust#47219). - I've removed `Journal::open_directory` and `Journal::open_files` entirely. They'll need to use the new `journal::OpenFileOptions` and `journal::OpenDirectoryOptions`. Co-authored-by: Cody P Schafer <dev@codyps.com>
|
Canceled. |
codyps
force-pushed
the
license-cleanup
branch
from
05802e1 to
461457e
Compare
|
bors r+ |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JournalFilesdoesn't properly cover all inclusions/exclusionsopen()call options meant).OpenOptions,OpenFileOptions, andOpenDirectoryOptionsare added. These are patterned afterstd::fs::OpenOptions.Journal::open()as deprecated (and was somewhat annoyed by Using deprecated items within the crate that deprecated them issues warnings rust-lang/rust#47219).Journal::open_directoryandJournal::open_filesentirely. They'll need to use the newjournal::OpenFileOptionsandjournal::OpenDirectoryOptions.