UMAPINFO: Introduce the new author field. #436
Conversation
|
Sure, why not. I am fine with this addition to the spec.
Is this the reason why there is no coresponding change in the code to actually print the new fields? |
I thought maybe people don't want these changes. Sure, this is trivial, I can add this to PrBoom+/Woof. |
Hmm, there are multiple musics defined per level (for intertext/etc.). Are these music fields purely for documentation or are they displayed in some way while music is playing back? Does it create any concern that not all music can be attributed to an author/composer? Just posing some upfront questions so we don't thrash on this. |
This is only for level music.
They are displayed on the "entering" status screen along with CWILV graphics.
That is the question for PWAD/UMAPINFO maker. |
Hmm, why do you say this? If we don't supply a field for it I don't understand how the WAD author/maker is expected to handle this. |
|
Sorry, I guess I don't understand. These are optional fields so that the PWAD/UMAPINFO creators can display MIDI music authors in-game if they want. |
Put more simply: Why is it important to provide a means to credit the author/composer of level music but not important to provide a means credit the author/composer of other musics? |
Well, I think there is no convenient place in-game to credit the authors of other musics. |
We could just pick a corner, lower-right for instance. Then it's up to the author to either exclude the field or ensure it is visible against the graphic backdrop. |
I don’t know, it’s distracting. So we need to add fields for all types of intermissions? I have seen several PWADs that indicated level and music authors graphically in CWILV graphics, but I have never seen PWAD that displayed authors of an intermission music in-game. |
|
Hm, mapinfo doesn't feel like the right place to have music info. There can be multiple music tracks in one level, and mapinfo doesn't cover all the places music appears. Thete are plenty of ways to credit music. If it's a big deal to you, I would suggest standardizing a music info lump that expressly assigns credit to songs, not maps. |
|
Also, why is this coming in the form of a PR and not an issue or a forum thread? |
I actually like this idea better too. Especially since we can have music changers which will allow multiple tracks per map (as pointed out above). |
rfomin
changed the title
|
Ok, I removed
This PR is inspired by this thread: [doomworld] |
|
Why hasn't this PR been merged yet? It's my understanding that the author field has already been adopted as part of the UMAPINFO specification (kraflab/umapinfo#1), but hasn't been implemented by any source port yet (from what i've seen). |
|
This PR either needs to copy the official spec file exactly or otherwise replace prboom+'s copy with a link to the official spec version. After that I'd agree it can be merged. |
prboom2/src/wi_stuff.c
Outdated
| y += (5 * V_NamePatchHeight(lname)) / 4; | ||
| } | ||
|
|
||
| if (wbs->nextmapinfo && wbs->nextmapinfo->author) |
There was a problem hiding this comment.
The spec stipulates that the author name is only printed when the levelpic doesn't exist and we are printing the level name (the above branch). In a lot of wads, the organizer includes the author in the patch along with the title.
|
The stats screen also needs to be updated ( |
The level
authorfield is supported by Eternity Engine in EMAPINFO (creator), GZDoom in ZMAPINFO (author), and Doom Retro in RMAPINFO (author).musictitleandmusiccomposerare taken from Doom Retro.In demo compatible ports, the status screen for "entering" in Doom 2 is very fast, barely enough time to read the name of the level.