Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows compatibility. #21

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fix Windows compatibility. #21

merged 1 commit into from
Jun 25, 2019

Conversation

kmgalanakis
Copy link
Contributor

This is a pull request for the issues described here #20.

@coenjacobs
Copy link
Owner

Thank you for this report and pull request! 👍 Don't the non-namespace directories (being moved right below your changes) need the same treatment?

@kmgalanakis
Copy link
Contributor Author

Thank you for this report and pull request! 👍 Don't the non-namespace directories (being moved right below your changes) need the same treatment?

Initially, I thought they didn't and I also thought I had tested that, but apparently I was wrong.

Anyway, it should be OK now. Can you please verify that my changes don't break anything for non-windows script executions?

Thanks for this great project.

@coenjacobs
Copy link
Owner

Ok, closing in on the next proper release. I want to take this in and therefore merging it in before I've tested all the edge cases possible. Will take this into intensive testing before release is done. Thanks!

@coenjacobs coenjacobs merged commit a7d54e1 into coenjacobs:master Jun 25, 2019
coenjacobs added a commit that referenced this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants