Delete original package directory #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages, including
twig/twig, have some safeguard mechanisms in place that prevent an older version (1.x) and a newer version (3.x) of the same package to be active. This is done by checking if the new version of the class is available, before loading the old version of the class.Use case where this was found: A plugin using Mozart to bundle Twig (on 3.x, preferably), while the theme used Twig 1.x without Mozart. Even though the replace went fine and the prefixed/namespaced classes of Twig are being used in the plugin, the version of Twig being loaded by the theme then still detected the new Twig version inside the
/vendordirectory which is being autoloaded. So, this pull request deletes the packages from the/vendordirectory after they have been moved to the new directory.This has been brought to my attention by @Willemijnr, who has been using my package in one of our Level Level projects - so props to her! 🎉