Skip to content

Commit

Permalink
[2/3] Bump grpc to 1.32.x to fix a too_many_pings regression
Browse files Browse the repository at this point in the history
Part 2: switch to v1.32.x

grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which  started failing in RBE with

io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings

grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings

Hopefully version bump to those helps

bazelbuild#12264

Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266

Also turn auto flow control feature back on

This reverts commit 6e94b05.

Closes bazelbuild#12288.

PiperOrigin-RevId: 337485572
  • Loading branch information
dmivankov authored and coeuvre committed Oct 22, 2020
1 parent 9c0010c commit 5f7413e
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 26 deletions.
50 changes: 25 additions & 25 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,11 @@ distdir_tar(
# protocolbuffers/protobuf
"v3.11.3.tar.gz",
# grpc/grpc
"v1.31.1.tar.gz",
"v1.32.0.tar.gz",
# c-ares/c-ares
"e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz",
# protocolbuffers/upb
"92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz",
"382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz",
# google/re2
"aecba11114cf1fac5497aeb844b6966106de3eb6.tar.gz",
# abseil/abseil-cpp
Expand Down Expand Up @@ -215,11 +215,11 @@ distdir_tar(
# protocolbuffers/protobuf
"v3.11.3.tar.gz": "cf754718b0aa945b00550ed7962ddc167167bd922b842199eeb6505e6f344852",
# grpc/grpc
"v1.31.1.tar.gz": "f20f92a09f7245e2c437fbd729849ffe3b2dd39a46c9378d201f8f95cc9f12ea",
"v1.32.0.tar.gz": "f880ebeb2ccf0e47721526c10dd97469200e40b5f101a0d9774eb69efa0bd07a",
# c-ares/c-ares
"e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz": "e8c2751ddc70fed9dc6f999acd92e232d5846f009ee1674f8aee81f19b2b915a",
# protocolbuffers/upb
"92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz": "79f7de61203c4ee5e4fcb2f17c5f3338119d6eb94aca8bce05332d2c1cfee108",
"382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz": "7992217989f3156f8109931c1fc6db3434b7414957cb82371552377beaeb9d6c",
# google/re2
"aecba11114cf1fac5497aeb844b6966106de3eb6.tar.gz": "9f385e146410a8150b6f4cb1a57eab7ec806ced48d427554b1e754877ff26c3e",
# abseil/abseil-cpp
Expand Down Expand Up @@ -298,19 +298,19 @@ distdir_tar(
"https://github.com/protocolbuffers/protobuf/archive/v3.11.3.tar.gz",
],
# grpc/grpc
"v1.31.1.tar.gz": [
"https://mirror.bazel.build/github.com/grpc/grpc/archive/v1.31.1.tar.gz",
"https://github.com/grpc/grpc/archive/v1.31.1.tar.gz",
"v1.32.0.tar.gz": [
# "https://mirror.bazel.build/github.com/grpc/grpc/archive/v1.32.0.tar.gz",
"https://github.com/grpc/grpc/archive/v1.32.0.tar.gz",
],
# c-ares/c-ares
"e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz": [
"https://mirror.bazel.build/github.com/c-ares/c-ares/archive/e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz",
"https://github.com/c-ares/c-ares/archive/e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz",
],
# protocolbuffers/upb
"92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz": [
"https://mirror.bazel.build/github.com/protocolbuffers/upb/archive/92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz",
"https://github.com/protocolbuffers/upb/archive/92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz",
"382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz": [
"https://mirror.bazel.build/github.com/protocolbuffers/upb/archive/382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz",
"https://github.com/protocolbuffers/upb/archive/382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz",
],
# google/re2
"aecba11114cf1fac5497aeb844b6966106de3eb6.tar.gz": [
Expand Down Expand Up @@ -557,11 +557,11 @@ distdir_tar(
# protocolbuffers/protobuf
"v3.11.3.tar.gz",
# grpc/grpc
"v1.31.1.tar.gz",
"v1.32.0.tar.gz",
# c-ares/c-ares
"e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz",
# protocolbuffers/upb
"92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz",
"382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz",
# google/re2
"aecba11114cf1fac5497aeb844b6966106de3eb6.tar.gz",
# abseil/abseil-cpp
Expand Down Expand Up @@ -591,11 +591,11 @@ distdir_tar(
# protocolbuffers/protobuf
"v3.11.3.tar.gz": "cf754718b0aa945b00550ed7962ddc167167bd922b842199eeb6505e6f344852",
# grpc/grpc
"v1.31.1.tar.gz": "f20f92a09f7245e2c437fbd729849ffe3b2dd39a46c9378d201f8f95cc9f12ea",
"v1.32.0.tar.gz": "f880ebeb2ccf0e47721526c10dd97469200e40b5f101a0d9774eb69efa0bd07a",
# c-ares/c-ares
"e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz": "e8c2751ddc70fed9dc6f999acd92e232d5846f009ee1674f8aee81f19b2b915a",
# protocolbuffers/upb
"92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz": "79f7de61203c4ee5e4fcb2f17c5f3338119d6eb94aca8bce05332d2c1cfee108",
"382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz": "7992217989f3156f8109931c1fc6db3434b7414957cb82371552377beaeb9d6c",
# google/re2
"aecba11114cf1fac5497aeb844b6966106de3eb6.tar.gz": "9f385e146410a8150b6f4cb1a57eab7ec806ced48d427554b1e754877ff26c3e",
# abseil/abseil-cpp
Expand Down Expand Up @@ -644,19 +644,19 @@ distdir_tar(
"https://github.com/protocolbuffers/protobuf/archive/v3.11.3.tar.gz",
],
# grpc/grpc
"v1.31.1.tar.gz": [
"https://mirror.bazel.build/github.com/grpc/grpc/archive/v1.31.1.tar.gz",
"https://github.com/grpc/grpc/archive/v1.31.1.tar.gz",
"v1.32.0.tar.gz": [
# "https://mirror.bazel.build/github.com/grpc/grpc/archive/v1.32.0.tar.gz",
"https://github.com/grpc/grpc/archive/v1.32.0.tar.gz",
],
# c-ares/c-ares
"e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz": [
"https://mirror.bazel.build/github.com/c-ares/c-ares/archive/e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz",
"https://github.com/c-ares/c-ares/archive/e982924acee7f7313b4baa4ee5ec000c5e373c30.tar.gz",
],
# protocolbuffers/upb
"92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz": [
"https://mirror.bazel.build/github.com/protocolbuffers/upb/archive/92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz",
"https://github.com/protocolbuffers/upb/archive/92e63da73328d01b417cf26c2de7b0a27a0f83af.tar.gz",
"382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz": [
"https://mirror.bazel.build/github.com/protocolbuffers/upb/archive/382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz",
"https://github.com/protocolbuffers/upb/archive/382d5afc60e05470c23e8de19b19fc5ad231e732.tar.gz",
],
# google/re2
"aecba11114cf1fac5497aeb844b6966106de3eb6.tar.gz": [
Expand Down Expand Up @@ -968,12 +968,12 @@ register_toolchains("//src/main/res:empty_rc_toolchain")
http_archive(
name = "com_github_grpc_grpc",
patch_args = ["-p1"],
patches = ["//third_party/grpc:grpc_1.31.1.patch"],
sha256 = "f20f92a09f7245e2c437fbd729849ffe3b2dd39a46c9378d201f8f95cc9f12ea",
strip_prefix = "grpc-1.31.1",
patches = ["//third_party/grpc:grpc_1.32.0.patch"],
sha256 = "f880ebeb2ccf0e47721526c10dd97469200e40b5f101a0d9774eb69efa0bd07a",
strip_prefix = "grpc-1.32.0",
urls = [
"https://mirror.bazel.build/github.com/grpc/grpc/archive/v1.31.1.tar.gz",
"https://github.com/grpc/grpc/archive/v1.31.1.tar.gz",
# "https://mirror.bazel.build/github.com/grpc/grpc/archive/v1.32.0.tar.gz",
"https://github.com/grpc/grpc/archive/v1.32.0.tar.gz",
],
sha256 = "2fcb7f1ab160d6fd3aaade64520be3e5446fc4c6fa7ba6581afdc4e26094bd81",
patches = ["//third_party/grpc:grpc_1.26.0.patch"],
Expand Down
2 changes: 1 addition & 1 deletion scripts/bootstrap/compile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ fi
GOOGLE_API_PROTOS="$(grep -o '".*\.proto"' third_party/googleapis/BUILD.bazel | sed 's/"//g' | sed 's|^|third_party/googleapis/|g')"
PROTO_FILES=$(find third_party/remoteapis ${GOOGLE_API_PROTOS} third_party/pprof src/main/protobuf src/main/java/com/google/devtools/build/lib/buildeventstream/proto src/main/java/com/google/devtools/build/skyframe src/main/java/com/google/devtools/build/lib/skyframe/proto src/main/java/com/google/devtools/build/lib/bazel/debug src/main/java/com/google/devtools/build/lib/starlarkdebug/proto -name "*.proto")
LIBRARY_JARS=$(find $ADDITIONAL_JARS third_party -name '*.jar' | grep -Fv JavaBuilder | grep -Fv third_party/guava | grep -ve 'third_party/grpc/grpc.*jar' | tr "\n" " ")
GRPC_JAVA_VERSION=1.31.1
GRPC_JAVA_VERSION=1.32.2
GRPC_LIBRARY_JARS=$(find third_party/grpc -name '*.jar' | grep -e ".*${GRPC_JAVA_VERSION}.*jar" | tr "\n" " ")
GUAVA_VERSION=25.1
GUAVA_JARS=$(find third_party/guava -name '*.jar' | grep -e ".*${GUAVA_VERSION}.*jar" | tr "\n" " ")
Expand Down

0 comments on commit 5f7413e

Please sign in to comment.