Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): ListCooccurrences API error #346

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Sep 17, 2024

When debugging cooccurrence issue, I found bug in ListCooccurrences API.
The API is almost just for debugging purpose, though.

  • minumim_should_match on queries with no should query causes 0 result when filter is set
  • remove unused sort-vote logic

- minumim_should_match on queries with no should query causes 0 result when filter is set
- remove unused sort-vote logic
@MrOrz MrOrz self-assigned this Sep 17, 2024
@MrOrz MrOrz added the bug label Sep 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 88.507% (+0.1%) from 88.398%
when pulling 14a6b66 on fix-list-cooccurrence
into 4857e9f on master.

@MrOrz MrOrz merged commit 79f9878 into master Sep 18, 2024
5 checks passed
@MrOrz MrOrz deleted the fix-list-cooccurrence branch September 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants