Upgrade node and npm packages #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because webpack 4 only supports nodejs 16 - webpack/webpack#14532
- Fix story name suggested by eslint - We cannot go beyond jest 26 because jest >= 27 breaks storyshot Ref: storybookjs/storybook#15916
nonumpa
reviewed
Apr 30, 2022
| @@ -33,7 +33,7 @@ exports[`Storyshots ActionMenu Default 1`] = ` | |||
| className="MuiButton-label" | |||
| > | |||
| <svg | |||
| aria-hidden="true" | |||
| aria-hidden={true} | |||
| className="MuiSvgIcon-root" | |||
| focusable="false" | |||
There was a problem hiding this comment.
Does storybook forget to change focusable="false" to focusable={false} ?
There was a problem hiding this comment.
Personally I don't know why this would change XD
For DOM elements, {true} and "true" are probably identical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm updateto Fix the dependabot PRs all at oncenode:16-alpineto shrink the production image sizenpm auditmain.jssupportsenvsetup, which fixes the "process is not defined" error in statically built storybook/storybook/index.htmlwill become viewable after this fix!