Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downvote dialog by proper null handling #487

Merged
merged 1 commit into from
May 13, 2022
Merged

Fix downvote dialog by proper null handling #487

merged 1 commit into from
May 13, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented May 13, 2022

Fixes #486. Root cause please see #486 (comment) .

I roughly checked other return value of useQuery(); other access of data prop are all properly guarded by ?..

圖片

@MrOrz MrOrz requested review from nonumpa, andyy0216 and bil4444 May 13, 2022 06:22
@MrOrz MrOrz self-assigned this May 13, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.531% when pulling 149ab49 on fix-downvote into 5326cca on master.

@MrOrz MrOrz merged commit affe465 into master May 13, 2022
@MrOrz MrOrz deleted the fix-downvote branch May 13, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

@andyy0216 andyy0216 Awaiting requested review from andyy0216

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot downvote categories
3 participants
@MrOrz @coveralls @bil4444