-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build instructions for all platforms & Containerfiles to compile app #89
Comments
Hi @emanuelb, After running instructions from README on plain repo and verifying all works (after fixing #88): git clone git@github.com:coffee-software/coffee.wallet.git
cd coffee.wallet
npm run build
./browserify.sh
cordova platform add browser
cordova run I was able to build APK on my linux with simply: cordova platform add android
cordova build android README refers to Cordova on purpose as there are many build systems for cordova depending on system you are on and system you are targeting, if you ate using containers etc. Thanks a lot for posting this thou as might be useful for someone building using podman, I will extend info in README. |
The reason a build script is needed is in order to specify the build environment and tools used to build the app (specific versions) in order to achieve reproducible builds, see related issue of testing coffee.wallet on walletscrutiny: https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/404 which I plan to do in future (compare the built APK to APK downloaded from GooglePlay) for more details: |
@emanuelb this is a great project and I would love to see Coffee Wallet verified there. I have added more info to README on building. https://github.com/coffee-software/coffee.wallet/blob/develop/README.md I have also added a Dockerfile that can be used to build using specific versions (used yours as loose reference, hope you don't mind): https://github.com/coffee-software/coffee.wallet/blob/develop/build/Dockerfile You can build app using docker buildkit like this: DOCKER_BUILDKIT=1 docker build -f build/Dockerfile -o . . It will produce Few issues I see:
|
Sure, feel free to modify & use it, other vendors Dockerfile are based on my scripts.
Yes, ping me when the next release is available.
Yes, Comparing built APK to APK from provider can be done with:
Then only files relates to signature should be shown.
Automatically no, either it require to look at the diff itself, or better what I usually do is in the RB script I download the APK file, unzip it, |
can you comment here which versions were used to generate this apk for version 0.22 on google play? I tested version 0.22 details in: https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/404#note_1361299141 it will be easier to test the next version that will use the Dockerfile in build directory. |
README.md should contain the full instructions on how to compile the app, currently there is a message that refer to cordova docs instead:
coffee.wallet/README.md
Line 43 in e056a49
while trying to compile the android app I uncover issue: #88
managed to compile APK with command:
podman build --pull --rm -t coffeewallet_debian_build_apk -f Containerfile
Containerfile content:
APK is generated in path:
/home/appuser/app/coffeewallet/coffee.wallet/platforms/android/app/build/outputs/apk/release/app-release-unsigned.apk
The text was updated successfully, but these errors were encountered: