common: implementing the timeout recovery stratefy #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
This command is implementing an idea that it is well tested in plugin like [1] and running in production for years now. In the years no better solution are been found, so we keep our incremental timeout for explora in case of failure. Only explora can change the answer after a while and the others from our tests are pretty stable (except nakamoto). In summary if an request fails the retry stratefy try 4 time with an incremental time, in this way also if the explora will ban us there is no problem because we have time to recover from the ban. [1] https://github.com/clightning4j/btcli4j Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Fixes #34