Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Memory Todo List Bot Behavior #54

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

In-Memory Todo List Bot Behavior #54

wants to merge 4 commits into from

Conversation

solomon-b
Copy link
Member

@solomon-b solomon-b commented Nov 20, 2022 •
edited
Loading

Adds a basic Todo List bot behavior, resolving #44:

<<< 📝 podcast-guests create
>>> List Created
<<< 📝 podcast-guests 📝 masaeedu
>>> List Updated
<<< 📝 podcast-guests 📝 boarders
>>> List Updated
<<< 📝 podcast-guests
>>> podcast-guests:
0. masaeedu
1. boarders

<<< list podcast-guests create
>>> List Created
<<< list podcast-guests add masaeedu
>>> List Updated
<<< list podcast-guests add boarders
>>> List Updated
<<< list podcast-guests
>>> podcast-guests:
0. masaeedu
1. boarders

TODO:

  • Pretty Printer for list output.
  • Multiple lists indexed by strings (ala sessionization of the calculator bot).
  • Finalize API

@solomon-b
Copy link
Member Author

solomon-b commented Nov 20, 2022 •
edited
Loading

@isovector

  • Is this a good API or do you want other commands?
  • Is it okay to leave it as in memory for now or should we write to disk?
  • How would you like the final pretty printed list to look?

@solomon-b solomon-b force-pushed the feature/todo-behavior branch 2 times, most recently from e113ee6 to 1aa5a59 Compare November 20, 2022 08:46
@isovector
Copy link
Contributor

I think we double down on emoji interfaces like the pear. Maybe we could use 📝 to add to a list and ✅ to remove from it.

@solomon-b
Copy link
Member Author

solomon-b commented Nov 20, 2022 •
edited
Loading

I think these are all the actions we want:

- create <list-name>
- delete <list-name>
- show <list-name>
- add <list-name> <text>
- remove <list-name> <list-entry-key>
- update <list-name> <list-entry-key> <text>

Does that seem right? Can you help pick emojis for all of them?

@solomon-b solomon-b force-pushed the feature/todo-behavior branch 3 times, most recently from a51db0b to 68a21db Compare November 20, 2022 21:36
@solomon-b solomon-b mentioned this pull request Nov 20, 2022
Merged
@solomon-b solomon-b force-pushed the feature/todo-behavior branch 6 times, most recently from 9bc7e02 to 3014283 Compare November 22, 2022 08:00
@solomon-b
Copy link
Member Author

solomon-b commented Nov 27, 2022 •
edited
Loading

@isovector I think this is ready to get merged. We can fine tune it based on how we end up using it:

<<< 📝 podcast-guests create
>>> List Created
<<< 📝 podcast-guests 📝 masaeedu
>>> List Updated
<<< 📝 podcast-guests 📝 boarders
>>> List Updated
<<< 📝 podcast-guests
>>> podcast-guests:
0. masaeedu
1. boarders

@solomon-b solomon-b linked an issue Nov 28, 2022 that may be closed by this pull request
Feature request: stateful lists #44
Open
@isovector
Copy link
Contributor

nice!

@solomon-b
Copy link
Member Author

nice!

I wanna wait to merge this til the testing PR merges.

@solomon-b solomon-b self-assigned this Dec 8, 2022
@isovector isovector removed their request for review March 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@solomon-b solomon-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: stateful lists
2 participants
@solomon-b @isovector