Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart guide amendments #123

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Quickstart guide amendments #123

merged 1 commit into from
Sep 25, 2023

Conversation

jezsadler
Copy link
Collaborator

  • fixed input/output queries to use .display() functions in README.rst and quickstart.rst
  • included optimal results in quickstart.rst
  • fixed a typo in quickstart.rst
  • Included instructions to install ipopt v 3.11.1 for Windows machines in installation.rst

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

- fixed input/output queries to use .display() functions in README.rst and quickstart.rst
- included optimal results in quickstart.rst
- fixed a typo in quickstart.rst
- Included instructions to install ipopt v 3.11.1 for Windows machines in installation.rst
@rmisener rmisener self-requested a review September 25, 2023 08:48
Copy link
Member

@rmisener rmisener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to have a fresh set of eyes looking at OMLT to tell us what doesn't make sense! Thnks @jezsadler

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.54% 🎉

Comparison is base (dcca13c) 95.40% compared to head (c0d5739) 95.95%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   95.40%   95.95%   +0.54%     
==========================================
  Files          26       29       +3     
  Lines        1371     1656     +285     
  Branches      192      254      +62     
==========================================
+ Hits         1308     1589     +281     
- Misses         34       35       +1     
- Partials       29       32       +3     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmisener rmisener merged commit c0f6c0b into cog-imperial:main Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants