Constraint Class #24
Merged
Constraint Class #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiralulam
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Constraint class that enables a more user friendly handling of constraints, as well as a delay between constraint definition and application to a model.
This is currently a draft pending a little more documentation and a few test cases. A jupyter notebook
constraint_classes.ipynbis provided to demonstrate the functionality.Let me know what you think! The aim is for useability, so let me know how it reads. My biggest issue at the moment is that creating the constraint requires the
ConcreteModel(for access to the variables) andProblemConfig.feat_list(for the names of the variables). This feels slightly clunky, but I think is necessary for how ENTMOOT is written.Also this currently only supports Pyomo, not Gurobi. If this works well for Pyomo then I'm happy to have a look at transferring over!
Thanks,
Toby