Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser Back button works, but causes other issues #1279

Open
gedw99 opened this issue Oct 30, 2024 · 1 comment · May be fixed by #1321
Open

Browser Back button works, but causes other issues #1279

gedw99 opened this issue Oct 30, 2024 · 1 comment · May be fixed by #1321
Assignees
@kkoreilly
Labels
bug Something isn't working correctly confirmed This bug has been confirmed
Milestone
v0.4

Comments

@gedw99
Copy link

gedw99 commented Oct 30, 2024 •
edited
Loading

Describe the bug

The browsers built in back button works but the state inside the wasm app gets very confused.

safari on Mac.

How to reproduce

https://www.cogentcore.org/core/widgets/other/html

then click to

https://www.cogentcore.org/core/widgets/other/pages

then click the rendered back button and everything works correctly.

then do all this again and click the built in browser back button and play around.

the URL is going backwards as it should, the the WASM GUI is not.

Example code

No response

Relevant output

Platform

same errors in:

macOS safari
macOS chrome
@gedw99 gedw99 added the bug Something isn't working correctly label Oct 30, 2024
@gedw99 gedw99 changed the title Back button works in Browser, but fails to sync the tree Back button works in Browser, but causes other issues Oct 30, 2024
@gedw99 gedw99 changed the title Back button works in Browser, but causes other issues Browser Back button works, but causes other issues Oct 30, 2024
@kkoreilly kkoreilly added the confirmed This bug has been confirmed label Oct 30, 2024
@kkoreilly kkoreilly self-assigned this Oct 30, 2024
@kkoreilly kkoreilly added this to the v0.4 milestone Oct 30, 2024
@kkoreilly
Copy link
Member

Thank you for reporting this! I will fix this soon.

@kkoreilly kkoreilly added this to Bugs Nov 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in Bugs Nov 18, 2024
kkoreilly added a commit that referenced this issue Nov 20, 2024
@kkoreilly
start on content popstate event for #1279
470fedd
kkoreilly added a commit that referenced this issue Nov 20, 2024
@kkoreilly
implement and use Content.getWebURL; mostly fixes #1279, although som…
339a97c 
…e issues with navigation remain
kkoreilly added a commit that referenced this issue Nov 20, 2024
@kkoreilly
do not add to history in Content.handleWebPopState; only do saveWebUR…
c81c4c4 
…L when adding to history; makes #1279 better, although still one more navigation issue
kkoreilly added a commit that referenced this issue Nov 20, 2024
@kkoreilly
don't push in Content.saveWebURL if we are already at the new URL; fu…
06e3654 
…lly fixes #1279 by removing duplicate history entries for first page
kkoreilly added a commit that referenced this issue Nov 20, 2024
@kkoreilly
do not display toolbar navigation on web in content since it is super…
088b4f5 
…seded by browser navigation (#1279)
@kkoreilly kkoreilly linked a pull request Nov 20, 2024 that will close this issue
Add Cogent Content, a new system for managing and displaying static web content #1321
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkoreilly kkoreilly

Labels
bug Something isn't working correctly confirmed This bug has been confirmed
Projects
Bugs
Status: In progress
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Add Cogent Content, a new system for managing and displaying static web content cogentcore/core
2 participants
@kkoreilly @gedw99