Feat/set profile in imagedata #688
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not 'scales' in dataset_profile: | ||
| dataset_profile['scales'] = dataset.scales | ||
| if not 'offsets' in dataset_profile: | ||
| dataset_profile['offsets'] = dataset.offsets |
There was a problem hiding this comment.
what if we want the scales and offsets info even if we don't apply them?
There was a problem hiding this comment.
alos I think if we add profile we should always populate the field, not just when we unscale=True
There was a problem hiding this comment.
well, i made it conditional on unscale request as to avoid issues with STAC and Mosaic readers.
I believe the profile probably is always available but i did this per your suggestion.
It would be easy to remove the condition and update the profile with "scales" and "offsets"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentsarago
This PR adds an optional profile attribute to ImageData in case the reader that created it was requested to unscale the data.
as per developmentseed/titiler#803
The profile attr will contain the scales and offsets, which at this point are not part of the profile attribute of the rio DatasetReader
This is to accomodate a specific use case when the reader is not STAC or Mosaic.