Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-5] FDM v3 support #228

Merged
merged 13 commits into from
May 10, 2023
Merged

[AI-5] FDM v3 support #228

merged 13 commits into from
May 10, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2023

https://cognitedata.atlassian.net/browse/AI-5

Problem / User story
Data modeling (FDM GA) is coming, and Granafa should support what it did on top of DMS v2 and Templates

Solution
Refactored DMS v2 glow to fit DMS v3 (data modeling in CDF)

Affected Resource types
FDM

Changes to datasource JSON model
FDM, breaking change to v2 (removed in favor for the GA flow)

Has documentation been updated
NO, please help and educate me how 🙏

Have tests been updated?
yes

Screenshots and examples
Screenshots and example query if applicable

image

Using platypus on greenfield (ask for full credential from @dlcognite ), use the above Data Model and version, with the following query
data model: Sample_Data_Model_With_Types in space Sample
version: 3
query:

query MyQuery {
  listWithPrimitives {
    items {
      timeseries {
        __typename
        externalId
      }
    }
  }
}

@ghost ghost self-requested a review March 17, 2023 18:04
@ghost ghost requested review from abdullah-cognite and polomani as code owners March 17, 2023 18:04
@polomani
Copy link
Contributor

polomani commented Mar 21, 2023

@dlcognite hi, thanks for the contribution!
I hope it's not time critical? We are a bit packed this-next week due to the cycle end, hope we can review it after?

Meanwhile, could you add a screenshot to the folder, so we can include it in the plugin metadata:
https://grafana.com/docs/grafana/latest/developers/plugins/metadata/ (see screenshots)

also, what's the project I can test it on?

@ghost
Copy link
Author

ghost commented Mar 21, 2023

No worries yet! We are waiting for a few features in the backend still, will ping when I need review!

@ghost
Copy link
Author

ghost commented Apr 3, 2023

working with timeseries
image

@ghost
Copy link
Author

ghost commented Apr 3, 2023

@polomani good sir, how do i document plugins and update screenshots?

@ghost
Copy link
Author

ghost commented Apr 3, 2023

also fixed the header style, was giving me anxiety 😓
image

@polomani
Copy link
Contributor

polomani commented Apr 3, 2023

@dlcognite the documentation is moved here https://docs.cognite.com/cdf/dashboards/guides/grafana/getting_started, so we don't necessarily have to merge the at the same time, but at least have some draft maybe?
Considering that this is GA soon, it's should be not a bad idea to document it officially?

Also, maybe it's time to add one-two unit tests for the FlexibleDataModellingDatasource.ts

@polomani
Copy link
Contributor

polomani commented Apr 3, 2023

@dlcognite regarding screenshots, here are the specs:
https://grafana.com/docs/writers-toolkit/writing-guide/image-guidelines/#screenshot-guidelines-1

Just put them in the images folder, I can help with referencing it in the plugin.json afterwards (or just look here https://grafana.com/docs/grafana/latest/developers/plugins/metadata/#properties-5)

@muradsater
Copy link
Contributor

Should we remove "Preview" from Data Models and enable by default? It will cause lots of questions if it's hidden behind the toggle in data source settings.

@ghost ghost changed the title FDM v3 support [AI-5] FDM v3 support May 8, 2023
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@polomani polomani merged commit 9c87726 into master May 10, 2023
@polomani polomani deleted the dl/fdm_v3_support branch May 10, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants