-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI-5] FDM v3 support #228
Conversation
@dlcognite hi, thanks for the contribution! Meanwhile, could you add a screenshot to the folder, so we can include it in the plugin metadata: also, what's the project I can test it on? |
No worries yet! We are waiting for a few features in the backend still, will ping when I need review! |
@polomani good sir, how do i document plugins and update screenshots? |
@dlcognite the documentation is moved here https://docs.cognite.com/cdf/dashboards/guides/grafana/getting_started, so we don't necessarily have to merge the at the same time, but at least have some draft maybe? Also, maybe it's time to add one-two unit tests for the |
@dlcognite regarding screenshots, here are the specs: Just put them in the images folder, I can help with referencing it in the plugin.json afterwards (or just look here https://grafana.com/docs/grafana/latest/developers/plugins/metadata/#properties-5) |
Should we remove "Preview" from Data Models and enable by default? It will cause lots of questions if it's hidden behind the toggle in data source settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
https://cognitedata.atlassian.net/browse/AI-5
Problem / User story
Data modeling (FDM GA) is coming, and Granafa should support what it did on top of DMS v2 and Templates
Solution
Refactored DMS v2 glow to fit DMS v3 (data modeling in CDF)
Affected Resource types
FDM
Changes to datasource JSON model
FDM, breaking change to v2 (removed in favor for the GA flow)
Has documentation been updated
NO, please help and educate me how 🙏
Have tests been updated?
yes
Screenshots and examples
Screenshots and example query if applicable
Using
platypus
on greenfield (ask for full credential from @dlcognite ), use the above Data Model and version, with the following querydata model:
Sample_Data_Model_With_Types
in spaceSample
version: 3
query: