Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Annotation editor to React #261

Merged
merged 18 commits into from
Oct 12, 2023
Merged

Migrate Annotation editor to React #261

merged 18 commits into from
Oct 12, 2023

Conversation

polomani
Copy link
Contributor

@polomani polomani commented Sep 22, 2023

Changes

  • return events in a data frame format

TODO

  • make sure backward compatibility (to engage with stakeholders)
  • tests (cypress?)
  • recheck UI
  • review removed code

Problem / User story
Angular-based plugins are being deprecated, we need to transition the Annotation editor panel to React.

Solution
If applicable, how has the problem been solved? E.g. Refactored out code to eliminate a bug

Affected Resource types
Events (annotations)

Changes to datasource JSON model
TBD
What has been updated in the JSON? Any fields added/removed, possible breaking changes?

Has documentation been updated
Yes/No

Have tests been updated?
Yes/No/Future PR

Screenshots and examples
Screenshots and example query if applicable

@sagar-thalwar sagar-thalwar marked this pull request as ready for review October 12, 2023 08:54
@sagar-thalwar sagar-thalwar requested a review from a team October 12, 2023 08:54
@abdullah-cognite abdullah-cognite merged commit af623f2 into master Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants