feat: add support for Unit conversion on Custom Time Series Queries #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertoncolling
requested review from
abdullah-cognite and
polomani
as code owners
polomani
changed the title
polomani
reviewed
Feb 6, 2024
| @@ -104,7 +104,7 @@ | |||
| "@grafana/schema": "^10.1.2", | |||
| "@grafana/ui": "^10.1.2", | |||
| "deepdash": "^4.5.4", | |||
| "eslint-plugin-jsdoc": "^40.1.1", | |||
| "eslint-plugin-jsdoc": "48.0.4", | |||
There was a problem hiding this comment.
PR looks good (with some limitations, that we discussed), but we need to bump the version and add a changelog.MD entry
There was a problem hiding this comment.
- Updated the help text for the custom query button mentioning the fact that we expose the unit and unitExternalId of the original data in the label
- Bumped the package version
- Added a changelog -> let me know if there are other things to mention there
polomani
added
auto-merge
…na-datasource into unit-coversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / User story
This PR adds support for performing unit conversion on custom time series queries
Solution
targetUnitandtargetUnitSystemin custom time series queriesunitExternalIdandunitQuantityunitExternalIdto time series and datapoints response types30-> https://atchison.dev/non-legacy-form-data-source-plugin-grafana/Affected Resource types
Time series
Changes to datasource JSON model
N/A
Has documentation been updated
Yes
Have tests been updated?
No
Screenshots and examples
