fix(deprecated-apis): remove backendSrv.datasourceRequest #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polomani
changed the title
lpereiracgn
reviewed
Feb 5, 2024
Comment on lines
-87
to
+110
| this.connector = new Connector( | ||
| const connector = new Connector( | ||
| this.project, | ||
| url, | ||
| this.backendSrv, | ||
| defaultFetcher, | ||
| oauthPassThru, | ||
| oauthClientCreds, | ||
| enableTemplates, | ||
| enableEventsAdvancedFiltering, | ||
| enableFlexibleDataModelling, | ||
| enableExtractionPipelines | ||
| ); | ||
| this.initSources(connector); | ||
| } | ||
|
|
||
| initSources (connector: Connector) { | ||
| this.connector = connector; |
There was a problem hiding this comment.
Why to move the connector init to a separate method instead of keeping it in the constructor?
There was a problem hiding this comment.
unfortunately constructor cannot accept any more params, seems like it's somehow forbidden by Grafana instance itself somewhere
lpereiracgn
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / User story
fetch()method, to encapsulate an HTTP client@grafana/runtime@^10.3.1type didn't play well with the ~10.2 (by just updating the dependency)