Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time zone support for timeseries #386

Merged
merged 13 commits into from
Jun 18, 2024
Merged

Add time zone support for timeseries #386

merged 13 commits into from
Jun 18, 2024

Conversation

lpereiracgn
Copy link
Contributor

@lpereiracgn lpereiracgn commented Jun 10, 2024 •
edited
Loading

  • This PR adds support for time zones in Timeseries, the user can select the timezone using the Grafana time range options.
    demo-tz

polomani
polomani reviewed Jun 10, 2024
View reviewed changes
src/cdf/client.ts Outdated Show resolved Hide resolved
@lpereiracgn lpereiracgn marked this pull request as ready for review June 12, 2024 11:53
@lpereiracgn lpereiracgn requested a review from a team June 12, 2024 11:53
polomani
polomani reviewed Jun 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
polomani
polomani reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@polomani polomani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good (description and version number has to be fixed)
We can merge it after the time series feature is GA

TODO before merge:

  • [] delete beta header
  • [] fix version and PR/commit description

@lpereiracgn lpereiracgn changed the title timezone support Add time zone support for timeseries Jun 13, 2024
matiascognite
matiascognite reviewed Jun 14, 2024
View reviewed changes
src/plugin.json Outdated Show resolved Hide resolved
polomani
polomani reviewed Jun 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
polomani
polomani reviewed Jun 17, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
polomani
polomani reviewed Jun 17, 2024
View reviewed changes
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@cognite/cognite-grafana-datasource",
"version": "4.1.3",
"version": "4.1.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump minor version, not patch, follow the semantic release guidelines

lpereiracgn and others added 3 commits June 17, 2024 19:11
@lpereiracgn @polomani
Update CHANGELOG.md
5f5cdc4 
Co-authored-by: Ivan Polomani <ivan.polomanyi@cognite.com>
@lpereiracgn @polomani
Update CHANGELOG.md
7baff06 
Co-authored-by: Ivan Polomani <ivan.polomanyi@cognite.com>
@lpereiracgn
bump version
70697b5
@polomani polomani merged commit 95e4374 into master Jun 18, 2024
3 checks passed
@polomani polomani deleted the timezone-support branch June 18, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiascognite matiascognite matiascognite left review comments

@polomani polomani polomani approved these changes

@abdullah-cognite abdullah-cognite Awaiting requested review from abdullah-cognite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpereiracgn @polomani @matiascognite