Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lower limits for create/update/delete of postgres gateway users #2105

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

einarmo
Copy link
Contributor

@einarmo einarmo commented Feb 3, 2025

Description

Set the limit for number of postgres gateway users to create/update/delete to 1.

These operations have a tendency to be extremely heavy, so the limits are low for now.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

These operations have a tendency to be extremely heavy, so the limits
are low for now.
@einarmo einarmo requested review from a team as code owners February 3, 2025 11:50
@einarmo einarmo requested a review from a team February 3, 2025 11:51
Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haakonvt
Copy link
Contributor

haakonvt commented Feb 3, 2025

Unrelated tests fail currently due to #2102 , I'll see if I can get that fixed by EOD. Set it to auto-merge if you want, and I'll see it through.

@haakonvt haakonvt enabled auto-merge (squash) February 3, 2025 23:26
@haakonvt haakonvt disabled auto-merge February 3, 2025 23:26
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (28faa0c) to head (4d7591e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2105   +/-   ##
=======================================
  Coverage   90.68%   90.69%           
=======================================
  Files         149      149           
  Lines       22881    22886    +5     
=======================================
+ Hits        20750    20756    +6     
+ Misses       2131     2130    -1     
Files with missing lines Coverage Δ
cognite/client/_api/postgres_gateway/users.py 94.64% <100.00%> (+0.52%) ⬆️

... and 3 files with indirect coverage changes

@einarmo einarmo merged commit 705ea61 into master Feb 4, 2025
16 checks passed
@einarmo einarmo deleted the limit-postgres-gateway-users branch February 4, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants