[NEAT-28] Extend DMS rules to lists #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikokaoja
approved these changes
Feb 26, 2024
| index: StrListType | None = Field(None, alias="Index") | ||
| constraint: StrListType | None = Field(None, alias="Constraint") | ||
|
|
||
| @field_validator("value_type", mode="before") |
There was a problem hiding this comment.
I guess this could not fit under _types.py ?
There was a problem hiding this comment.
It is only used here, which is why I do not put it into the types.
| return ViewEntity.from_raw(value) | ||
| return value | ||
|
|
||
| @field_serializer("value_type", when_used="unless-none") |
|
|
||
|
|
||
| class DMSContainer(SheetEntity): | ||
| class_: str | None = Field(None, alias="Class") | ||
| container: ContainerType = Field(alias="Container") | ||
| description: str | None = Field(None, alias="Description") | ||
| constraint: ContainerType | None = Field(None, alias="Constraint") | ||
| constraint: ContainerListType | None = Field(None, alias="Constraint") | ||
|
|
||
| def as_container(self, default_space: str) -> dm.ContainerApply: |
| @@ -50,7 +51,7 @@ def rules_schema_tests_cases() -> Iterable[ParameterSet]: | |||
| DMSProperty( | |||
| class_="WindFarm", | |||
| property_="WindTurbines", | |||
| value_type="WindTurbine", | |||
| value_type=ViewEntity(suffix="WindTurbine"), | |||
There was a problem hiding this comment.
Do you have a before validation that auto-create ViewEntity if only string is passed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes to better cover all DMS possibilities:
ViewEntityif the relation column is set. This means we now support referring to views which are in a different space than the default set in the metadata sheet, and an arbitrary version.The next are more esoteric, less important, but gives us a better cover of DMS rules