[NEAT-27] DMS sheet validation #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikokaoja
approved these changes
Feb 26, 2024
| ] | ||
|
|
||
|
|
||
| StrListType = Annotated[ | ||
| list[str], | ||
| BeforeValidator(lambda value: [entry.strip() for entry in value.split(",")] if isinstance(value, str) else value), | ||
| PlainSerializer( |
There was a problem hiding this comment.
Is this used when exporting rules to e.g. Excel?
There was a problem hiding this comment.
It is used when you call .model_dump
|
|
||
| value_types = {prop.value_type for prop in properties if prop.value_type} | ||
| if len(value_types) > 1: | ||
| exceptions.append( |
There was a problem hiding this comment.
Define these as NeatExceptions
| ) | ||
| list_definitions = {prop.is_list for prop in properties if prop.is_list is not None} | ||
| if len(list_definitions) > 1: | ||
| exceptions.append( |
| ) | ||
| nullable_definitions = {prop.nullable for prop in properties if prop.nullable is not None} | ||
| if len(nullable_definitions) > 1: | ||
| exceptions.append( |
| ) | ||
| default_definitions = {prop.default for prop in properties if prop.default is not None} | ||
| if len(default_definitions) > 1: | ||
| exceptions.append( |
| ) | ||
| index_definitions = {",".join(prop.index) for prop in properties if prop.index is not None} | ||
| if len(index_definitions) > 1: | ||
| exceptions.append( |
| ) | ||
| constraint_definitions = {",".join(prop.constraint) for prop in properties if prop.constraint is not None} | ||
| if len(constraint_definitions) > 1: | ||
| exceptions.append( |
|
|
||
| if exceptions: | ||
| exception_str = "\n".join(exceptions) | ||
| raise ValueError(f"Inconsistent container(s): {exception_str}") |
There was a problem hiding this comment.
You can actually use ExceptionGroup for this,
For python lower than 3.11, make sure to import this:
if sys.version_info < (3, 11):
from exceptiongroup import ExceptionGroup
There was a problem hiding this comment.
I tried, but pydantic was not happy.
# Conflicts: # cognite/neat/rules/models/_rules/dms_architect_rules.py # tests/tests_unit/rules/test_models/test_dms_architect_rules.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validations added:
In addition, allow you to only define index and constraint on a container property only the first row you define it. You can set the rest to zero.
Instead of
You can now do:
