[NEAT-41] Export to CDF and Integration Test #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
commented
Feb 29, 2024
| T_WritableCogniteResourceList = TypeVar("T_WritableCogniteResourceList", bound=WriteableCogniteResourceList) | ||
|
|
||
|
|
||
| class ResourceLoader( |
There was a problem hiding this comment.
This is steeling a concept from cdf-toolkit. However, I thing it is equally useful for us to be able to tell the user results of dry runs and have a standardized interface towards cognite resources.
nikokaoja
approved these changes
Mar 1, 2024
| from dataclasses import dataclass, field | ||
| from functools import total_ordering | ||
|
|
||
|
|
There was a problem hiding this comment.
should we call this module _models ? not really religious
| def delete(self, ids: SequenceNotStr[DataModelId]) -> list[DataModelId]: | ||
| return self.client.data_modeling.data_models.delete(cast(Sequence, ids)) | ||
|
|
||
| def are_equal(self, local: DataModelApply, remote: DataModel) -> bool: |
There was a problem hiding this comment.
I like this local and remote. We should remebre to use same naming for Asset Loader.
There was a problem hiding this comment.
That is already there in the new AssetLoader implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall got the DMS Export to DMS to work in the first iteration (still more validation to add). On the way I ran into multiple obstacles that resulted in the following.
DMSExporters.export_to_cdf.