Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEAT-36] Sanitize Errors. #287

Merged
merged 28 commits into from
Mar 3, 2024
Merged

[NEAT-36] Sanitize Errors. #287

merged 28 commits into from
Mar 3, 2024

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Mar 1, 2024 •
edited
Loading

  • Introduce rules.validation package to handle all validation classes and eventually formatter.
  • Changed the interface for importers to return validation issues.
  • Changed ExcelImporter to have option for returning all validation issues.
  • Fix: Missing float32 in _DMS_TYPES
  • Container Inconsistent Errors introduced.
  • DMSSchema Errors put into context of the Validation package.
  • Use the header line in the report to get correct row number in report.

nikokaoja
nikokaoja approved these changes Mar 1, 2024
View reviewed changes
cognite/neat/rules/importers/_models.py Outdated


@dataclass
class Issue:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the name of the class :)

cognite/neat/rules/importers/_owl2rules/_owl2rules.py
"Metadata": parse_owl_metadata(graph, make_compliant=make_compliant),
"Classes": parse_owl_classes(graph, make_compliant=make_compliant),
"Properties": parse_owl_properties(graph, make_compliant=make_compliant),
"Metadata": parse_owl_metadata(graph, make_compliant=self.make_compliant),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice

cognite/neat/rules/importers/_spreadsheet2rules.py Outdated
raise MetadataSheetMissingOrFailedValidation() from None
else:
raise UserWarning("Metadata sheet is missing or failed validation") from e
issues.append(MetadataSheetMissingOrFailedValidationError())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@doctrino
fix: parsing of
09ce73e 
inconsistency container definitons
@doctrino doctrino marked this pull request as ready for review March 3, 2024 12:17
@doctrino doctrino merged commit 527c84e into main Mar 3, 2024
6 checks passed
@doctrino doctrino deleted the sanitize-errors branch March 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikokaoja nikokaoja nikokaoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doctrino @nikokaoja