[NEAT-62] Cleanup Validation -> Issues Module #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikokaoja
approved these changes
Mar 16, 2024
| @@ -0,0 +1,27 @@ | |||
| from . import dms, fileread, formatters, importing, spreadsheet, spreadsheet_file | |||
|
|
||
|
|
||
| @dataclass(frozen=True, order=True) | ||
| class ClassNoPropertiesNoParentsWarning(ValidationWarning): |
There was a problem hiding this comment.
There are couple of issues which depending on the use case can be warning or error. Is this possible with the current setup?
There was a problem hiding this comment.
Then, you would have to duplicate have one error and one warning version of the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code is moving round existing classes and renaming. That accounts for most of the changes in code-lines.
Changes:
rules.valiadiontorules.issues__init__.pyand make all submodules of the newrules.issuespublic such that you can use the modules for navigation. E.g.from cognite.neat.rules import issuesand thenissues.dms.MissingSpacesError.Errorand all warnings have suffixWarning. Introduced test to enforce this standard.