[NEAT-107] Cleanup validation module part2 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
force-pushed
the
cleanup-validation-module-part2
branch
from
a3b933f to
2c47562
Compare
…dule-part2 # Conflicts: # cognite/neat/rules/issues/base.py # cognite/neat/rules/issues/dms.py # cognite/neat/rules/issues/fileread.py # cognite/neat/rules/issues/importing.py # cognite/neat/rules/issues/spreadsheet.py # cognite/neat/rules/issues/spreadsheet_file.py # tests/tests_unit/rules/test_issues/test_issues_metatests.py
This was referenced Mar 16, 2024
Merged
nikokaoja
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Most the issues data classes have set
order=True. The problem with this is that issues can only be sorted with other issues of the same type. (The default ordering methods you get from dataclasses by settingorder=Trueis too strict for our use case)Solution
Removed the
order=Trueand implemented a__lt__and__eq__on the base class that will be used by all child classes to sort.