[Prep for NEAT-48] Refactor: _DMSExporter #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule-part2 # Conflicts: # cognite/neat/rules/issues/base.py # cognite/neat/rules/issues/dms.py # cognite/neat/rules/issues/fileread.py # cognite/neat/rules/issues/importing.py # cognite/neat/rules/issues/spreadsheet.py # cognite/neat/rules/issues/spreadsheet_file.py # tests/tests_unit/rules/test_issues/test_issues_metatests.py
This was referenced Mar 17, 2024
Merged
…tion-list # Conflicts: # cognite/neat/rules/issues/dms.py
nikokaoja
approved these changes
Mar 18, 2024
| data_model.space = used_spaces.pop() | ||
| spaces = dm.SpaceApplyList([dm.SpaceApply(space=data_model.space)]) | ||
| else: | ||
| spaces = dm.SpaceApplyList([metadata.as_space()] + [dm.SpaceApply(space=space) for space in used_spaces]) |
There was a problem hiding this comment.
doesn't DMSMetadata have field space already, why calling method?
There was a problem hiding this comment.
To get the space object
| else: | ||
| type_cls = dm.DirectRelation | ||
|
|
||
| prop_name = to_camel(prop.container_property) if self.standardize_casing else prop.container_property |
There was a problem hiding this comment.
For time being this is fine, but we already have under SheetEntity defined option to add name field, in case for example when property_ and class_ (i.e. ids) are human unreadable, which is the case for one of our clients.
There was a problem hiding this comment.
Not sure if I understand this. Are you suggesting a better way to handle properties?
# Conflicts: # tests/tests_unit/rules/test_models/test_dms_architect_rules.py
# Conflicts: # cognite/neat/rules/models/_rules/dms_architect_rules.py # tests/tests_unit/rules/test_models/test_dms_architect_rules.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refactoring the
_DMSExporterby gathering and moving out the methods for creating the containers, views, and spaces.This is necessary as with adding filter to the views the code became very messy. Dragging this out as its own PR to separate the refactoring from actually adding the feature.