Split Transformation export from DMS and Release 0.68.0 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
doctrino
commented
Mar 19, 2024
•
doctrino
commented
doctrino
changed the title
doctrino
changed the title
doctrino
commented
Mar 19, 2024
| @@ -570,7 +570,7 @@ def _create_spaces( | |||
| spaces = dm.SpaceApplyList([dm.SpaceApply(space=data_model.space)]) | |||
| else: | |||
| spaces = dm.SpaceApplyList([metadata.as_space()] + [dm.SpaceApply(space=space) for space in used_spaces]) | |||
| if self.instance_space: | |||
| if self.instance_space and self.instance_space not in {space.space for space in spaces}: | |||
doctrino
commented
Mar 19, 2024
Comment on lines
+81
to
+92
| if self.export_components.intersection({"all", "spaces"}): | ||
| for space in schema.spaces: | ||
| zip_ref.writestr(f"data_models/{space.space}.space.yaml", space.dump_yaml()) | ||
| if self.export_components.intersection({"all", "data_models"}): | ||
| for model in schema.data_models: | ||
| zip_ref.writestr(f"data_models/{model.external_id}.datamodel.yaml", model.dump_yaml()) | ||
| if self.export_components.intersection({"all", "views"}): | ||
| for view in schema.views: | ||
| zip_ref.writestr(f"data_models/{view.external_id}.view.yaml", view.dump_yaml()) | ||
| if self.export_components.intersection({"all", "containers"}): | ||
| for container in schema.containers: | ||
| zip_ref.writestr(f"data_models/{container.external_id}.container.yaml", container.dump_yaml()) |
alivinco
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.