Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neat 318 add query module to graph #508

Merged
merged 22 commits into from
Jun 24, 2024
Merged

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Jun 20, 2024

[0.82.00] - 21-06-24

Added

  • Introduce query module under neat.graph which holds previous _Queries class
  • Added generation of SPARQL CONSTRUCT queries based on rdfpath transformations defined in InformationRules
  • Introduce NeatGraphStore.read method which takes class and returns all instances of that class
  • Test for NeatGraphStore.read method which entails end-to-end process of loading triples, inferring data model and reading instances of a class

Changed

  • DMSLoader now uses .read method of NeatGraphStore

Copy link

github-actions bot commented Jun 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
21743 15360 71% 60% 🟢

New Files

File Coverage Status
cognite/neat/graph/queries/init.py 100% 🟢
cognite/neat/graph/queries/_base.py 61% 🟢
cognite/neat/graph/queries/_construct.py 83% 🟢
cognite/neat/graph/queries/_shared.py 42% 🟢
TOTAL 71% 🟢

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/graph/extractors/_mock_graph_generator.py 19% 🟢
cognite/neat/graph/loaders/_rdf2dms.py 74% 🟢
cognite/neat/graph/stores/_base.py 68% 🟢
cognite/neat/rules/analysis/_information_rules.py 84% 🟢
cognite/neat/rules/importers/_inference2rules.py 91% 🟢
cognite/neat/rules/models/information/_rules.py 86% 🟢
cognite/neat/rules/models/information/_rules_input.py 96% 🟢
cognite/neat/utils/utils.py 83% 🟢
TOTAL 78% 🟢

updated for commit: 5507ac2 by action🐍

Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this PR correctly, this is mainly moving code around, it is not much new.

The only thing that reacted to, should the queries package be inside the store? As it is mostly a helper, and not a core concept, like extractors, store, loader, or transformer

@nikokaoja nikokaoja merged commit 6a89223 into main Jun 24, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-318-Add-query-module-to-graph branch June 24, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants