Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEAT-331] 🙃Multivalue conversion #513

Merged
merged 5 commits into from
Jun 25, 2024
Merged

[NEAT-331] 🙃Multivalue conversion #513

merged 5 commits into from
Jun 25, 2024

Conversation

doctrino
Copy link
Collaborator

No description provided.

@@ -271,3 +278,24 @@ def _bump_suffix(suffix: str) -> str:
return suffix[: suffix_number.start()] + str(int(suffix_number.group()) + 1)
else:
return f"{suffix}2"

@staticmethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classmethod :)

return data_types.Double()
elif not (py_types - {datetime, date}):
return data_types.DateTime()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :) and elegant

@doctrino doctrino merged commit b326c88 into main Jun 25, 2024
7 checks passed
@doctrino doctrino deleted the multivalue-conversion branch June 25, 2024 11:17
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22026 15524 70% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/rules/models/information/_converter.py 92% 🟢
TOTAL 96% 🟢

updated for commit: 4d0afc9 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants