Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neat 341 inference importer issues with namespace prefix collision #530

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Jul 7, 2024

[0.85.5] - 04-07-24

Fixed

  • Prefix collision
  • Fixed issue arising when value string "null" is threated as float "null" leading to error
    in DMS Instances

Removed

  • Relation to original data model used to develop neat

nikokaoja and others added 3 commits July 7, 2024 18:00
* ci: fix 2

* build: bump

* build: style fix

* ci: newest version
* Push image to f25e common container registry

* fix new line

* Update client id

* add gha token

* add seperate job to push image to f25e container registry

* fix new line at eof

* Remove env from docker image push job

* Remove scsproduction tag

* Bumo poetry gha version

* add acr login step

* Clean redundant steps

* build: bump

---------

Co-authored-by: anders-albert <anders0albert@gmail.com>
Copy link

github-actions bot commented Jul 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22437 15665 70% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/constants.py 100% 🟢
cognite/neat/graph/loaders/_rdf2dms.py 74% 🟢
cognite/neat/legacy/graph/examples/init.py 0% 🟢
cognite/neat/legacy/graph/extractors/_dexpi.py 94% 🟢
cognite/neat/legacy/graph/loaders/core/rdf_to_assets.py 79% 🟢
cognite/neat/legacy/rules/examples/init.py 100% 🟢
cognite/neat/rules/exporters/_rules2excel.py 87% 🟢
cognite/neat/rules/importers/_inference2rules.py 91% 🟢
cognite/neat/rules/issues/spreadsheet.py 75% 🟢
cognite/neat/rules/models/information/_rules.py 87% 🟢
cognite/neat/rules/models/information/_rules_input.py 96% 🟢
cognite/neat/rules/models/information/_validation.py 86% 🟢
cognite/neat/workflows/steps/lib/legacy/graph_store.py 48% 🟢
TOTAL 80% 🟢

updated for commit: fbd74d4 by action🐍

Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup :)

Comment on lines -25 to -32
"cim": Namespace("http://iec.ch/TC57/2013/CIM-schema-cim16#"),
"icim": Namespace("http://iec.ch/TC57/2013/CIM-schema-cim16-info#"),
"entsoe": Namespace("http://entsoe.eu/CIM/SchemaExtension/3/1#"),
"entsoe2": Namespace("http://entsoe.eu/CIM/SchemaExtension/3/2#"),
"md": Namespace("http://iec.ch/TC57/61970-552/ModelDescription/1#"),
"pti": Namespace("http://www.pti-us.com/PTI_CIM-schema-cim16#"),
"tnt": Namespace("http://purl.org/cognite/tnt#"),
"neat": DEFAULT_NAMESPACE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪦

@@ -271,7 +271,7 @@ def _class2asset_instance(
if "name" in remapped_class_instance and remapped_class_instance["name"] == "":
remapped_class_instance["name"] = empty_name_default
# To maintain shape across of all assets of specific type we are adding missing metadata
# keys as empty strings, this was request by Statnett
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤫

@nikokaoja nikokaoja merged commit a73b224 into main Jul 8, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-341-InferenceImporter-Issues-with-namespace-prefix-collision branch July 8, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants