[NEAT-343] 🎢 Asset Migration Toy Example Tutorial #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
commented
Jul 9, 2024
Comment on lines
+283
to
+292
| for instance_type, instances in {"Nodes": upserted.nodes, "Edges": upserted.edges}.items(): | ||
| result = UploadResult[InstanceId](name=instance_type, issues=read_issues) | ||
| for instance in instances: # type: ignore[attr-defined] | ||
| if instance.was_modified and instance.created_time == instance.last_updated_time: | ||
| result.created.add(instance.as_id()) | ||
| elif instance.was_modified: | ||
| result.changed.add(instance.as_id()) | ||
| else: | ||
| result.unchanged.add(instance.as_id()) | ||
| yield result |
There was a problem hiding this comment.
This change to the code is to get a better feedback to the user.
Instead of
We now get
nikokaoja
approved these changes
Jul 9, 2024
| issues = NeatIssueList[NeatIssue]() | ||
| items = [] | ||
| if items: | ||
| yield self._upload_to_cdf(client, items, dry_run, issues) | ||
| yield from self._upload_to_cdf(client, items, dry_run, issues) | ||
|
|
||
| @abstractmethod | ||
| def _get_required_capabilities(self) -> list[Capability]: |
There was a problem hiding this comment.
considering issue that we bump into when client IAM did not have any cap. do we have a fall back when loader will attempt to push things to CDF?
There was a problem hiding this comment.
Not sure what you mean here.
| result.changed.add(instance.as_id()) | ||
| else: | ||
| result.unchanged.add(instance.as_id()) | ||
| yield result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.