[NEAT-344] 🙉 Custom Asset Types #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
nikokaoja
approved these changes
Jul 9, 2024
| """Converts an asset to triples.""" | ||
| id_ = namespace[f"Asset_{asset.id}"] | ||
|
|
||
| # Set rdf type | ||
| triples: list[Triple] = [(id_, RDF.type, namespace["Asset"])] | ||
| type_ = "Asset" | ||
| if self.to_type: |
| @@ -14,9 +14,14 @@ def test_asset_extractor(): | |||
|
|
|||
| store = NeatGraphStore.from_memory_store() | |||
|
|
|||
| extractor = AssetsExtractor.from_dataset(client_mock, data_set_external_id="nordic44") | |||
| extractor = AssetsExtractor.from_dataset( | |||
| client_mock, data_set_external_id="nordic44", to_type=lambda a: a.metadata.get("type", "Unknown") | |||
There was a problem hiding this comment.
Should .get have default fall back to "Asset"?
There was a problem hiding this comment.
It was just to demonstrate that you can fallback to whatever you would like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed many files because I renamed
remove_namespacetoremove_namespace_from_uri. The motivation for this renaming was to haveremove_namespaceas a parameter in functions/methods that use theremove_namespace_from_uri.