Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neat 355 inference importer json string value type #536

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

nikokaoja
Copy link
Collaborator

[0.85.9] - 09-07-24

Added

  • Option for checking for JSON value type when inferring data model

Copy link

github-actions bot commented Jul 9, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22501 15714 70% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/graph/extractors/_classic_cdf/_assets.py 91% 🟢
cognite/neat/graph/extractors/_classic_cdf/_events.py 81% 🟢
cognite/neat/graph/extractors/_classic_cdf/_files.py 78% 🟢
cognite/neat/graph/extractors/_classic_cdf/_sequences.py 82% 🟢
cognite/neat/graph/extractors/_classic_cdf/_timeseries.py 76% 🟢
cognite/neat/rules/importers/_inference2rules.py 91% 🟢
cognite/neat/rules/models/data_types.py 99% 🟢
TOTAL 87% 🟢

updated for commit: 9e3eca8 by action🐍

Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize now that you made not made unpacking the metadata the default. I think metadata should be unpacked by default. The reason is that the most basic case (least skilled user) this is the desired behavior.

@nikokaoja nikokaoja merged commit 47605d2 into main Jul 9, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-355-InferenceImporter-JSON-string-value-type branch July 9, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants