Neat 334 asset loader graph store interface #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrino
reviewed
Jul 17, 2024
doctrino
approved these changes
Jul 17, 2024
Comment on lines
-12
to
-15
| _DEXPI_PREFIXES = { | ||
| "dexpi": Namespace("http://sandbox.dexpi.org/rdl/"), | ||
| "posccaesar": Namespace("http://data.posccaesar.org/rdl/"), | ||
| } |
| @@ -104,6 +134,39 @@ def categorize_assets(self, client: CogniteClient) -> None: | |||
|
|
|||
| raise NotImplementedError("Not implemented yet, this is placeholder") | |||
|
|
|||
| def _load(self, stop_on_exception: bool = False) -> Iterable[AssetWrite | NeatIssue]: | |||
There was a problem hiding this comment.
This is such a nice method. Really like how easy it is with the store.read
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0.87.0] - 17-07-24
Added
AssetLoaderadded to load assets to CDFget_default_prefixesmethod to provide default prefixesRemoved
PREFIXESdict that was used as default prefixes inNeatGraphStoreandRulesImproved
AssetRulesproperties have now mandatoryimplementationfieldFixed
DESCRIBEquery