[NEAT-374, NEAT-368 Part 2]👻 Refactor utility module part2 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikokaoja
approved these changes
Jul 18, 2024
| @@ -12,7 +12,7 @@ | |||
| from cognite.neat.constants import DEFAULT_NAMESPACE | |||
| from cognite.neat.graph.extractors._base import BaseExtractor | |||
| from cognite.neat.graph.models import Triple | |||
| from cognite.neat.utils.utils import create_sha256_hash, string_to_ideal_type | |||
| from cognite.neat.utils.auxiliary import create_sha256_hash, string_to_ideal_type | |||
There was a problem hiding this comment.
:) finally it is renamed :D , I like the new name of module
| @@ -15,8 +15,8 @@ | |||
| from cognite.neat.legacy.graph.stores import NeatGraphStoreBase | |||
| from cognite.neat.legacy.rules.models import Rules | |||
| from cognite.neat.legacy.rules.models.rules import Property | |||
| from cognite.neat.utils import remove_namespace_from_uri | |||
| from cognite.neat.utils.utils import epoch_now_ms | |||
| from cognite.neat.utils.rdf_ import remove_namespace_from_uri | |||
There was a problem hiding this comment.
nice to move rdf specific methods to appropriate submodule
There was a problem hiding this comment.
is there a reason for having _ at the end of the module?
There was a problem hiding this comment.
To avoid naming conflicts, but might now be necessary.
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.