Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping up asset loader #551

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Wrapping up asset loader #551

merged 14 commits into from
Jul 19, 2024

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Jul 18, 2024 •
edited
Loading

[0.87.3] - 18-07-24

Added

  • Handling of missing parents when generating assets
  • Concept of orphanage asset for assets whose parents do not exist
  • Uploader to CDF for assets

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22879 16064 70% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/graph/loaders/_rdf2asset.py 71% 🟢
cognite/neat/rules/analysis/_asset.py 84% 🟢
cognite/neat/rules/models/asset/_validation.py 100% 🟢
cognite/neat/rules/models/entities.py 88% 🟢
cognite/neat/utils/upload.py 47% 🟢
TOTAL 82% 🟢

updated for commit: a30e026 by action🐍

@nikokaoja nikokaoja marked this pull request as ready for review July 19, 2024 09:54
@nikokaoja nikokaoja requested a review from a team as a code owner July 19, 2024 09:54
doctrino
doctrino approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions otherwise great.

Ideally, I think this is worth an integration tests as well.

tests/tests_unit/graph/test_loaders/test_asset_loader.py Show resolved Hide resolved
cognite/neat/graph/loaders/_rdf2asset.py Outdated Show resolved Hide resolved
cognite/neat/graph/loaders/_rdf2asset.py Outdated Show resolved Hide resolved
cognite/neat/graph/loaders/_rdf2asset.py Outdated Show resolved Hide resolved
@nikokaoja @doctrino
Update cognite/neat/graph/loaders/_rdf2asset.py
fe68ad0 
Co-authored-by: Anders Albert <60234212+doctrino@users.noreply.github.com>
@nikokaoja nikokaoja merged commit 2922497 into main Jul 19, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-375-Wrap-AssetLoader branch July 19, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctrino doctrino doctrino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikokaoja @doctrino