Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEAT-353] 😯Remove regex from inference. #563

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

doctrino
Copy link
Collaborator

@doctrino doctrino commented Jul 23, 2024

Did one measurement. Unlikely to say whether this is an improvement, but think it will have an impact bigger graph. In addition, tried to format the comment based on number of value types.

image

Copy link

github-actions bot commented Jul 23, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
23000 16078 70% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/rules/importers/_inference2rules.py 90% 🟢
TOTAL 90% 🟢

updated for commit: e6ed19b by action🐍

Copy link
Collaborator

@nikokaoja nikokaoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great that usage of f strings!

@doctrino doctrino merged commit 0a77e72 into main Jul 23, 2024
7 checks passed
@doctrino doctrino deleted the speed-up-inference branch July 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants