Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove pipeline abstraction #144

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Conversation

dbrattli
Copy link
Contributor

@dbrattli dbrattli commented Jan 30, 2024

Simplify Oryx by removing the pipeline abstraction. Oryx can now only be used for HTTP handlers. This should make the code easier to read and type hints easier to understand.

@dbrattli dbrattli requested a review from a team as a code owner January 30, 2024 12:07
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #144 (168f45b) into master (a521683) will decrease coverage by 0.45%.
The diff coverage is 68.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   77.74%   77.29%   -0.45%     
==========================================
  Files           9        9              
  Lines         692      674      -18     
  Branches       41       40       -1     
==========================================
- Hits          538      521      -17     
+ Misses        127      126       -1     
  Partials       27       27              
Files Coverage Δ
src/Exception.fs 14.28% <ø> (ø)
src/Fetch.fs 91.54% <ø> (ø)
src/HttpContext.fs 88.00% <ø> (ø)
src/Logging.fs 95.12% <100.00%> (ø)
src/Metrics.fs 100.00% <ø> (ø)
src/Builder.fs 90.00% <50.00%> (ø)
src/Error.fs 65.04% <81.81%> (ø)
src/Core.fs 0.00% <0.00%> (ø)
src/HttpHandler.fs 73.00% <68.18%> (ø)

@dbrattli dbrattli merged commit 2ac2e0e into master Apr 18, 2024
5 checks passed
@dbrattli dbrattli deleted the simplify-remove-pipeline branch April 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants