-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New scenarios and bid config to match multi scenario 20 in v0, plus improved names, and adding 0.01 to buy_price #370
Conversation
…mproved names, and adding 0.01 to buy_price
80216b6
to
5cef506
Compare
…es-and-buy-price-plus-0.01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I think it'd be better if this notebook were consistent in creating a JSON object because right now, you have no2_price_scenario_mappings
that are created as a JSON, but then in plants
, you're printing each individual line out as a formatted string.
I also would suggest that this notebook directly dumps the JSON into the YAML file as opposed to printing out the YAML dump and copy-pasting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, but not sure I'll prioritise this now (and I think of the notebook as a hacky thing which is useful for avoiding some manual work, but maybe not the perfect way to set up these resources - maybe it should not be in the repo?)
Dumping to the yaml files should also be done with some caution in case there are some parts in the yaml file that should not be overwritten - then it would be good with multiple files for the same kind of config (such that the notebook or some other code could dump things into "its own" set of files).
…es-and-buy-price-plus-0.01
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 49.00% 48.89% -0.11%
==========================================
Files 566 566
Lines 40200 40286 +86
==========================================
Hits 19698 19698
- Misses 20502 20588 +86 |
…es-and-buy-price-plus-0.01
Description
Checklist: