Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POWEROPS-2557] chore: ruff linters #399

Merged
merged 6 commits into from
Jul 26, 2024
Merged

[POWEROPS-2557] chore: ruff linters #399

merged 6 commits into from
Jul 26, 2024

Conversation

nodegard
Copy link
Contributor

Description

Please describe the change you have made.

Checklist:

@@ -197,9 +201,10 @@ def validate_shop_related_files(cls, value):

@classmethod
def instantiate_from_dict(cls, config: dict) -> CogShopConfig:
time_series_mappings_v2 = []
for time_series_mapping in config["time_series_mappings_v2"]:
time_series_mappings_v2.append(TimeSeriesMappingV2.load_from_dict(time_series_mapping))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping removed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rewrote the for loop into a list comprehension

Copy link

@notrixbe notrixbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!
think only 1 thing to check

@nodegard nodegard merged commit f7d4e92 into main Jul 26, 2024
6 checks passed
@nodegard nodegard deleted the chore/ruff-linters branch July 26, 2024 09:42
@nodegard nodegard changed the title chore: ruff linters [POWEROPS-2556] chore: ruff linters Jul 31, 2024
@nodegard nodegard changed the title [POWEROPS-2556] chore: ruff linters [POWEROPS-2557] chore: ruff linters Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants