-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POWEROPS-2557] chore: ruff linters #399
Conversation
@@ -197,9 +201,10 @@ def validate_shop_related_files(cls, value): | |||
|
|||
@classmethod | |||
def instantiate_from_dict(cls, config: dict) -> CogShopConfig: | |||
time_series_mappings_v2 = [] | |||
for time_series_mapping in config["time_series_mappings_v2"]: | |||
time_series_mappings_v2.append(TimeSeriesMappingV2.load_from_dict(time_series_mapping)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapping removed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just rewrote the for loop into a list comprehension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
think only 1 thing to check
Description
Please describe the change you have made.
Checklist: